This repository was archived by the owner on Mar 17, 2021. It is now read-only.
fix: allow the usage of an empty string as publicPath #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request enforces a more strict check of `publicPath` to prevent the interpretation of empty string as false value. This allows to disable the prefixing of `publicPath` with `__webpack_public_path__` without the need to provide a function that simply returns the `url` as given.
Current work around would be to use
```js
query: {
publicPath: (url) => url
}
```
michael-ciniawsky
changed the title
|
Closed in favour of #145. Thx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enforces a more strict check of
publicPathto prevent the interpretation of empty string as false value. This allows to disable the prefixing ofpublicPathwith__webpack_public_path__without the need to provide a function that simply returns theurlas given.Current work around would be to use