This repository was archived by the owner on Mar 17, 2021. It is now read-only.
feat: Apply webpack-defaults v1.x #165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Retains index.js file history - Assumes proposed change to npm@5 - Assumes proposed appveyor proposal
src/index.js
Outdated
| import loaderUtils from 'loader-utils'; | ||
|
|
||
| export default function fileLoader(content) { | ||
| this.cacheable && this.cacheable(); // eslint-disable-line no-unused-expressions |
There was a problem hiding this comment.
This isn't needed with webpack >= v2.0.0, I know the PR 'just' applies webpack-defaults for the moment, so could be done later, but it's a simple change so maybe :)
There was a problem hiding this comment.
No, you're right about that. File loader was the guinea pig for defaults. It's being redone only to retain the git history on the lib files and to save me the trouble of having to rebase in changes on a file that was deleted on this branch :)
|
|
||
| const filePath = this.resourcePath; | ||
| if (config.useRelativePath) { | ||
| const issuerContext = this._module && this._module.issuer // eslint-disable-line no-underscore-dangle |
There was a problem hiding this comment.
Maybe we should relax some of these ESLint rules or are these lines subject to change in a smaller upcoming PR by intention ?
michael-ciniawsky
approved these changes
Jun 5, 2017
|
The CI problem is a linux only thing, i'll figure it out this afternoon. |
This was referenced Jun 6, 2017
joshwiens
force-pushed
the
d3viant0ne-Defaults
branch
from
0c46ff9 to
68ab09f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
If relevant, did you update the README?
Summary
Can't rebase in the changes from master given the
index.jsin the old defaults upgrade was deleted.Has the latest proposed changes to defaults ( appveyor & npm@5 )
Does this PR introduce a breaking change?
Breaking Change - Enforces NodeJS > 4.3 via engines.
Must release as semver
MAJOROther information