Skip to content

Partial of 291 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 9, 2021
Merged

Partial of 291 #377

merged 14 commits into from
Mar 9, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Mar 9, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

refactor

Breaking Changes

No

Additional Info

fixes #364 + fixes edge cases for some requests

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #377 (e3385c4) into master (6ae2c14) will decrease coverage by 0.84%.
The diff coverage is 81.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   96.45%   95.60%   -0.85%     
==========================================
  Files           7        7              
  Lines         564      569       +5     
  Branches      164      172       +8     
==========================================
  Hits          544      544              
- Misses         20       24       +4     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/utils.js 94.60% <78.66%> (-1.55%) ⬇️
src/plugins/sources-plugin.js 100.00% <100.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae2c14...e3385c4. Read the comment docs.

@alexander-akait alexander-akait merged commit 39e4966 into master Mar 9, 2021
@alexander-akait alexander-akait deleted the partial-of-291 branch March 9, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant