Skip to content

chore: add Node.js 10 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: add Node.js 10 #136

wants to merge 2 commits into from

Conversation

DanielRuf
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

test mini-css-extract-plugin on Node.js 10

Breaking Changes

none

Additional Info

@alexander-akait
Copy link
Member

@DanielRuf Better place for this https://github.com/webpack-contrib/webpack-defaults and when we update to latest default 👍 Also looks broken on node10 😞

@DanielRuf
Copy link
Author

Probably not broken but just a wrong image name

Error response from daemon: repository webpackcontrib/circleci-node10 not found: does not exist or no pull access

@DanielRuf
Copy link
Author

Yep, no Node.js 10 image, just 6, 8 and 9.

https://github.com/webpack-contrib/circleci-node9/blob/master/Dockerfile

@alexander-akait
Copy link
Member

@DanielRuf looks we need create image for node 10 (like this https://github.com/webpack-contrib/circleci-jdk9-node9)

If you want help us with webpack and webpack-contrib, it may be helpful to give you more permission on webpack-contrib. Looks on you github profile I would be glad to see such a person in our webpack and webpack-contrib orgs. But it's not in my competence.

/cc @d3viant0ne

@joshwiens
Copy link
Member

i'll get the docker container for node 10 setup this morning

@joshwiens joshwiens self-assigned this May 9, 2018
@joshwiens
Copy link
Member

@DanielRuf
Copy link
Author

So I guess this should work then. Will test and trigger a new build. Thanks for creating the image and the great collaboration 👍

@DanielRuf
Copy link
Author

Build looks good =)

@alexander-akait
Copy link
Member

@DanielRuf btw will be great add container to https://github.com/webpack-contrib/webpack-defaults

@DanielRuf
Copy link
Author

Done, see webpack-contrib/webpack-defaults#116

Was a pleasure, great collaboration =) 👍

@michael-ciniawsky
Copy link
Member

Closing in favor of webpack-contrib/webpack-defaults#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants