-
-
Notifications
You must be signed in to change notification settings - Fork 387
chore: add Node.js 10 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DanielRuf Better place for this https://github.com/webpack-contrib/webpack-defaults and when we update to latest default 👍 Also looks broken on node10 😞 |
Probably not broken but just a wrong image name
|
Yep, no Node.js 10 image, just 6, 8 and 9. https://github.com/webpack-contrib/circleci-node9/blob/master/Dockerfile |
@DanielRuf looks we need create image for node 10 (like this https://github.com/webpack-contrib/circleci-jdk9-node9) If you want help us with /cc @d3viant0ne |
i'll get the docker container for node 10 setup this morning |
So I guess this should work then. Will test and trigger a new build. Thanks for creating the image and the great collaboration 👍 |
Build looks good =) |
@DanielRuf btw will be great add container to |
Done, see webpack-contrib/webpack-defaults#116 Was a pleasure, great collaboration =) 👍 |
Closing in favor of webpack-contrib/webpack-defaults#116 |
This PR contains a:
Motivation / Use-Case
test mini-css-extract-plugin on Node.js 10
Breaking Changes
none
Additional Info