This repository was archived by the owner on Oct 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
refactor: apply webpack-defaults #55
Open
joshwiens
wants to merge
7
commits into
master
Choose a base branch
from
d3viant0ne-WebpackDefaults
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1cf4573
refactor: webpack-defaults init
joshwiens 6fb8e56
refactor: initial defaults pass
joshwiens 122d2c8
refactor: initial defaults pass
joshwiens 37b65b0
refactor: move default config to lib
joshwiens 5f4f764
refactor: consistant test folder name
joshwiens 0656855
chore(package): remove karma dependencies
joshwiens 92b0dc7
chore: Update to defaults 1.5.0
joshwiens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"presets": [ | ||
[ | ||
"env", | ||
{ | ||
"useBuiltIns": true, | ||
"targets": { | ||
"node": "4.3" | ||
}, | ||
"exclude": [ | ||
"transform-async-to-generator", | ||
"transform-regenerator" | ||
] | ||
} | ||
] | ||
], | ||
"plugins": [ | ||
[ | ||
"transform-object-rest-spread", | ||
{ | ||
"useBuiltIns": true | ||
} | ||
] | ||
], | ||
"env": { | ||
"test": { | ||
"presets": [ | ||
"env" | ||
], | ||
"plugins": [ | ||
"transform-object-rest-spread" | ||
] | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# editorconfig.org | ||
|
||
[*] | ||
charset = utf-8 | ||
indent_style = space | ||
indent_size = 2 | ||
end_of_line = lf | ||
insert_final_newline = true | ||
trim_trailing_whitespace = true | ||
|
||
[.md] | ||
insert_final_newline = false | ||
trim_trailing_whitespace = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
/node_modules | ||
/dist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"extends": "webpack", | ||
"rules": { | ||
"no-underscore-dangle": [1, { "allowAfterThis": true }], | ||
"no-plusplus": 1, | ||
"consistent-return": 1, | ||
"no-multi-assign": 1, | ||
"no-param-reassign": 1, | ||
"prefer-destructuring": 1, | ||
"no-nested-ternary": 1, | ||
"prefer-rest-params": 1, | ||
"import/no-unresolved": 1, | ||
"import/extensions": 1, | ||
"no-useless-escape": 1, | ||
"no-undefined": 1, | ||
"no-cond-assign": 1 | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
yarn.lock -diff | ||
* text=auto | ||
bin/* eol=lf | ||
package-lock.json -diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<!-- | ||
1. Check the version of package you are using. If it's not the newest version, update and try again (see changelog while updating!). | ||
2. If the issue is still there, write a minimal project showing the problem and expected output. | ||
3. Link to the project and mention Node version and OS in your report. | ||
|
||
**IMPORTANT! You should use [Stack Overflow](https://stackoverflow.com/) for support related questions.** | ||
--> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<!-- | ||
1. [Read and sign the CLA](https://cla.js.foundation/webpack/webpack.js.org). This needs to be done only once. PRs that haven't signed it won't be accepted. | ||
2. Check out the [development guide](https://webpack.js.org/development/) for the API and development guidelines. | ||
3. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort. | ||
--> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
sudo: false | ||
dist: trusty | ||
language: node_js | ||
branches: | ||
only: | ||
- master | ||
jobs: | ||
fast_finish: true | ||
allow_failures: | ||
- env: WEBPACK_VERSION=canary | ||
include: | ||
- &test-latest | ||
stage: Webpack latest | ||
node_js: 6 | ||
env: WEBPACK_VERSION=latest JOB_PART=test | ||
script: npm run travis:$JOB_PART | ||
- <<: *test-latest | ||
node_js: 4.3 | ||
env: WEBPACK_VERSION=latest JOB_PART=test | ||
script: npm run travis:$JOB_PART | ||
- <<: *test-latest | ||
node_js: 8 | ||
env: WEBPACK_VERSION=latest JOB_PART=lint | ||
script: npm run travis:$JOB_PART | ||
- <<: *test-latest | ||
node_js: 8 | ||
env: WEBPACK_VERSION=latest JOB_PART=coverage | ||
script: npm run travis:$JOB_PART | ||
after_success: 'bash <(curl -s https://codecov.io/bash)' | ||
- stage: Webpack canary | ||
before_script: npm i --no-save git://github.com/webpack/webpack.git#master | ||
script: npm run travis:$JOB_PART | ||
node_js: 8 | ||
env: WEBPACK_VERSION=canary JOB_PART=test | ||
before_install: | ||
- 'if [[ `npm -v` != 5* ]]; then npm i -g npm@^5.0.0; fi' | ||
- nvm --version | ||
- node --version | ||
- npm --version | ||
before_script: | ||
- |- | ||
if [ "$WEBPACK_VERSION" ]; then | ||
npm i --no-save webpack@$WEBPACK_VERSION | ||
fi | ||
script: | ||
- 'npm run travis:$JOB_PART' | ||
after_success: | ||
- 'bash <(curl -s https://codecov.io/bash)' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
branches: | ||
only: | ||
- master | ||
init: | ||
- git config --global core.autocrlf input | ||
environment: | ||
matrix: | ||
- nodejs_version: '8' | ||
webpack_version: latest | ||
job_part: test | ||
- nodejs_version: '6' | ||
webpack_version: latest | ||
job_part: test | ||
- nodejs_version: '4.3' | ||
webpack_version: latest | ||
job_part: test | ||
build: 'off' | ||
matrix: | ||
fast_finish: true | ||
install: | ||
- ps: Install-Product node $env:nodejs_version x64 | ||
- npm install | ||
before_test: | ||
- cmd: npm install webpack@%webpack_version% | ||
test_script: | ||
- node --version | ||
- npm --version | ||
- cmd: npm run appveyor:%job_part% |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional or left over ?