Skip to content
This repository was archived by the owner on Oct 9, 2020. It is now read-only.

refactor: changed React.PropTypes to standalone prop-types package #70

Closed
wants to merge 2 commits into from
Closed

refactor: changed React.PropTypes to standalone prop-types package #70

wants to merge 2 commits into from

Conversation

hafuta
Copy link

@hafuta hafuta commented Oct 15, 2017

refactor: changed React.PropTypes to standalone prop-types package, added yarn.lock file

@jsf-clabot
Copy link

jsf-clabot commented Oct 15, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@oayres
Copy link

oayres commented Nov 1, 2017

@d3viant0ne @sairion @kinetifex Sorry to directly tag you guys, but is there any chance this can be merged and published to npm please?

Copy link
Member

@joshwiens joshwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use yarn in contrib, remove the lock file

@@ -16,8 +16,8 @@ var IconSVG = React.createClass({
};
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire block is deprecated & removed in #55.

@hafuta
Copy link
Author

hafuta commented Nov 22, 2017

@d3viant0ne removed yarn.lock

@hafuta hafuta closed this Jan 4, 2018
@hafuta
Copy link
Author

hafuta commented Jan 4, 2018

Closing

@hafuta hafuta deleted the refactor/prop-types branch January 4, 2018 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants