Skip to content

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
Enhancement

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Nope

Summary
Added the ability to scaffold loader template in a specified path. Addresses #2021

Does this PR introduce a breaking change?
Nope

Other information
#2021 (comment)

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner November 8, 2020 18:17
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #2072 (25cb3a4) into master (8651f49) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
+ Coverage   68.31%   68.51%   +0.20%     
==========================================
  Files          77       76       -1     
  Lines        2408     2414       +6     
  Branches      496      497       +1     
==========================================
+ Hits         1645     1654       +9     
+ Misses        763      760       -3     
Impacted Files Coverage Δ
packages/generate-loader/src/index.ts 100.00% <100.00%> (ø)
packages/serve/src/startDevServer.ts 85.71% <0.00%> (-5.60%) ⬇️
packages/utils/src/modify-config-helper.ts 54.09% <0.00%> (-0.91%) ⬇️
packages/init/src/index.ts 100.00% <0.00%> (ø)
packages/generate-plugin/src/index.ts 100.00% <0.00%> (ø)
packages/webpack-cli/lib/utils/to-kebab-case.js
packages/generators/src/init-generator.ts 94.00% <0.00%> (+0.06%) ⬆️
packages/webpack-cli/lib/utils/arg-utils.js 66.66% <0.00%> (+25.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8651f49...25cb3a4. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we have to provide that specified path ?

@jamesgeorge007
Copy link
Member Author

how do we have to provide that specified path?

webpack-cli loader [path]

@snitin315
Copy link
Member

Lets document it.

alexander-akait
alexander-akait previously approved these changes Nov 9, 2020
snitin315
snitin315 previously approved these changes Nov 9, 2020
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add for #2073 too? Since I missed reviewing it before merge

@snitin315
Copy link
Member

/cc @anshumanv

@jamesgeorge007 jamesgeorge007 merged commit cd09f85 into master Nov 9, 2020
@jamesgeorge007 jamesgeorge007 deleted the feat/loader branch November 9, 2020 14:55
@jamesgeorge007
Copy link
Member Author

/cc @anshumanv

Oops, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants