feat(generate-loader): scaffold in a specified path #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
force-pushed
the
feat/loader
branch
from
e4368fa to
0a9d1c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2072 +/- ##
==========================================
+ Coverage 68.31% 68.51% +0.20%
==========================================
Files 77 76 -1
Lines 2408 2414 +6
Branches 496 497 +1
==========================================
+ Hits 1645 1654 +9
+ Misses 763 760 -3
Continue to review full report at Codecov.
|
snitin315
reviewed
Nov 9, 2020
|
|
Lets document it. |
alexander-akait
previously approved these changes
Nov 9, 2020
snitin315
previously approved these changes
Nov 9, 2020
anshumanv
reviewed
Nov 9, 2020
jamesgeorge007
dismissed stale reviews from snitin315 and alexander-akait
via
c60ebc0
jamesgeorge007
force-pushed
the
feat/loader
branch
from
c60ebc0 to
25cb3a4
Compare
alexander-akait
approved these changes
Nov 9, 2020
snitin315
approved these changes
Nov 9, 2020
|
/cc @anshumanv |
Oops, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Nope
Summary
Added the ability to scaffold
loadertemplate in a specified path. Addresses #2021Does this PR introduce a breaking change?
Nope
Other information
#2021 (comment)