Skip to content

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
tests

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
N/A

Summary
Follow up of #2073

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner November 9, 2020 12:15
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #2082 (d7033b9) into master (7d97efe) will increase coverage by 0.04%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
+ Coverage   68.45%   68.50%   +0.04%     
==========================================
  Files          76       76              
  Lines        2400     2413      +13     
  Branches      495      497       +2     
==========================================
+ Hits         1643     1653      +10     
- Misses        757      760       +3     
Impacted Files Coverage Δ
packages/serve/src/startDevServer.ts 85.71% <66.66%> (-5.60%) ⬇️
packages/generate-plugin/src/index.ts 100.00% <100.00%> (ø)
packages/generators/src/init-generator.ts 94.00% <100.00%> (+0.06%) ⬆️
packages/init/src/index.ts 100.00% <100.00%> (ø)
packages/utils/src/modify-config-helper.ts 54.09% <100.00%> (-0.91%) ⬇️
packages/utils/src/scaffold.ts 76.00% <100.00%> (ø)
packages/webpack-cli/lib/utils/package-exists.js 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb11f19...d7033b9. Read the comment docs.

@alexander-akait
Copy link
Member

Weird, coverage is reduced

@snitin315
Copy link
Member

It's increased now.

@alexander-akait alexander-akait merged commit 2f37538 into master Nov 9, 2020
@alexander-akait alexander-akait deleted the tests/plugin branch November 9, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants