fix(serve): do not default port in webpack-dev-server v4 #2126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2126 +/- ##
==========================================
+ Coverage 68.65% 68.70% +0.04%
==========================================
Files 74 74
Lines 2393 2390 -3
Branches 510 512 +2
==========================================
- Hits 1643 1642 -1
+ Misses 750 748 -2
Continue to review full report at Codecov.
|
| @@ -33,16 +39,21 @@ export default function startDevServer(compiler, devServerArgs): object[] { | |||
| devServerOptions.forEach((devServerOpts): void => { | |||
| const options = mergeOptions(cliOptions, devServerOpts); | |||
| options.host = options.host || 'localhost'; | |||
There was a problem hiding this comment.
@ylemkimon I think we have a problem here too, I think we used 0.0.0.0 by default here, we should use the same logic as used in Node.js http/https module
There was a problem hiding this comment.
But let's solve this in other PR
There was a problem hiding this comment.
Changing the default hostname would be a breaking change for webpack-cli.
There was a problem hiding this comment.
Let's do it only for v4
There was a problem hiding this comment.
I think it's better done on the dev-server's side.
There was a problem hiding this comment.
Actually the default host was localhost in the webpack-dev-server CLI: https://github.com/webpack/webpack-dev-server/blob/4ab1f21bc85cc1695255c739160ad00dc14375f1/bin/options.js#L175
There was a problem hiding this comment.
Yes, but I think it is bug and we should fix it, ideally we should be like
const http = require('http');
const requestListener = function (req, res) {
res.writeHead(200);
res.end('Hello, World!');
}
const server = http.createServer(requestListener);
server.listen(8080);
console.log(server.address())
:: for IPv6
0.0.0.0 for IPv4
What kind of change does this PR introduce?
Bug fix and refactor
Did you add tests for your changes?
Unit tests. Integration tests will be possible once after webpack-dev-server v4 has been released.
If relevant, did you update the documentation?
N/A
Summary
With webpack/webpack-dev-server#2845, webpack-dev-server will handle setting the default port.
Depends on the PR above.
Does this PR introduce a breaking change?
N/A
Other information