[WIP]: make browser tab should open via Node API #1657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
requested review from
alexander-akait and
michael-ciniawsky
as code owners
lib/Server.js
Outdated
| this.middleware.invalidate(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's merge #1658 first and when rebase 👍
|
/cc @hiroppy let's rebase 👍 |
|
/cc @hiroppy let's solve this too |
|
/cc @hiroppy let's solve this problem in next release, can you rebase? |
|
I am busy this week so I will fix this issue next week:) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1510
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Migrate migrate
webpack-dev-server.js's listen function toserver.js.Breaking Changes
no
Additional Info
Wait for #1658