Skip to content

Fix Routes test and add new server creation helpers #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No, but the bug is in a test.

Motivation / Use-Case

Solves this issue: #1734.

I ran into this issue while creating a fix for this: #1703. The fix I made for that problem extends the initial compilation time and makes the Routes test fail, so I thought it would be good to solve this before going further.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #1735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1735   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files           8        8           
  Lines         541      541           
  Branches      162      162           
=======================================
  Hits          466      466           
  Misses         62       62           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4297e...2cc0ee6. Read the comment docs.

@alexander-akait alexander-akait merged commit a827a65 into webpack:master Mar 23, 2019
@alexander-akait
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Google Summer of Code type: test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants