Skip to content

refactor(client): overlay #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019
Merged

refactor(client): overlay #2003

merged 1 commit into from
Jun 10, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 9, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

We want to add tests.

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 9, 2019 00:48
@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #2003 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
+ Coverage   92.52%   92.77%   +0.25%     
==========================================
  Files          28       29       +1     
  Lines        1083     1149      +66     
  Branches      324      327       +3     
==========================================
+ Hits         1002     1066      +64     
- Misses         77       79       +2     
  Partials        4        4
Impacted Files Coverage Δ
client-src/default/overlay.js 96.96% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce81c69...0805a7a. Read the comment docs.

@hiroppy hiroppy merged commit 90d4a7c into master Jun 10, 2019
@hiroppy hiroppy deleted the feature/refactor-overlay branch June 10, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants