feat(client): 'ws' clientMode #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
+ Coverage 94.46% 94.74% +0.28%
==========================================
Files 32 32
Lines 1210 1256 +46
Branches 334 360 +26
==========================================
+ Hits 1143 1190 +47
+ Misses 65 64 -1
Partials 2 2
Continue to review full report at Codecov.
|
wizardofhogwarts
approved these changes
Jul 10, 2019
|
/cc @Loonride something wrong with node@6 😕 |
I think this was just a very unsuccessful e2e test run, not particular to node 6. Unless there is something in the output that I missed |
hiroppy
approved these changes
Jul 10, 2019
knagaitsev
added a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
* feat(client): ws client mode * test(client): changed client and client mode tests to use arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Adds
clientMode: 'ws'with tests to confirm that it works, including full e2e tests.Breaking Changes
None
Additional Info