chore: rename isLocalIp flag

[rishabh3112]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

No (would add if needed)

Motivation / Use-Case

Keeping flags' syntax consistent overall

Breaking Changes

Maybe?

Additional Info

webpack/webpack-cli#1640

[knagaitsev]

Probably should be done for liveReload CLI flag as well. We can ignore serveIndex because it will be replaced in this PR: #2670.

Yes, this a breaking change, as it is --useLocalIp vs --use-local-ip.

@evilebottnawi Do you think this should go on v4 due to breaking changes?

[alexander-akait]

@Loonride Yes, we should do for liveReload, I think it is more bug fixes, because webpack-cli also in rc, and do not use this

[alexander-akait]

But let's merge it for v4

[codecov]

Codecov Report

Merging #2672 into v4 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v4    #2672   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files          37       37           
  Lines        1310     1310           
  Branches      354      354           
=======================================
  Hits         1212     1212           
  Misses         93       93           
  Partials        5        5           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b667b4...51bb2a0. Read the comment docs.

[knagaitsev]

We should also update in here then, correct? https://github.com/webpack/webpack-dev-server/blob/master/bin/options.js

[rishabh3112]

@Loonride will update the PR with requested changes soon.
It's been long time since I dig into dev server's codebase, so wasn't well aware of implications of those changes 😅.

[alexander-akait]

/cc @hiroppy

[alexander-akait]

Thanks!