Skip to content

chore(deps): upgrade http-proxy-middleware #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(deps): upgrade http-proxy-middleware #2750

wants to merge 1 commit into from

Conversation

moonflare
Copy link

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

  • N/A

Motivation

  • Update the http-proxy-middleware package for two main reasons:
    • In the last version of the upgraded package, the lodash dependency was updated to solve a security fix. Please see the PR in lodash repo with the fix
    • By upgrading to the last version of this package, we also solve another security issue that was addressed in a different PR (#2665) but didn't get the change to get merged.

Breaking Changes

This PR should not introduce a breaking change

Additional Info

  • Ran the unit tests locally and everything passes.
  • Checked all the examples and everything still works.
  • I noticed that in the previous PR (#2665) "ignoreDeps": ["http-proxy-middleware"] wasn't removed from renovate.json, so not entirely sure if it can/should be removed or not. Please let me know if we need it still

@jsf-clabot
Copy link

jsf-clabot commented Sep 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2750 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2750   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          34       34           
  Lines        1333     1333           
  Branches      381      381           
=======================================
  Hits         1250     1250           
  Misses         81       81           
  Partials        2        2           
Impacted Files Coverage Δ
lib/Server.js 96.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab1f21...97107c4. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change - node verison, it is solved in v4 branch, release will be in near future

@moonflare
Copy link
Author

Breaking change - node verison, it is solved in v4 branch, release will be in near future

Oh. I see. Thanks for the quick review and apologies for the noise. Will wait for the v4 and close this PR 🙏🏻

@moonflare moonflare closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants