-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: show detailed error in overlay for webpack 5 #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will fix CI problem today/tomorrow and merge it
Codecov Report
@@ Coverage Diff @@
## v4 #2811 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 39 39
Lines 1308 1309 +1
Branches 348 349 +1
=======================================
+ Hits 1217 1218 +1
Misses 87 87
Partials 4 4
Continue to review full report at Codecov.
|
I think we need increase timeout in some tests |
We need fix tests, please run it locally |
I see a different test is failing each time. I will check it locally. |
I can confirm all tests pass locally. I think we need a retry logic for flaky tests. Until then could you try closing and reopening the PR? |
@ylemkimon we are try it many times, I think we need fix tests, because after this change the problem appears |
For Bugs and Features; did you add new tests?
Not yet
Motivation / Use-Case
Fixes #2786, fixes #2760
Breaking Changes
No
Additional Info