Skip to content

fix: show detailed error in overlay for webpack 5 #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix: show detailed error in overlay for webpack 5 #2811

merged 1 commit into from
Nov 17, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Nov 3, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Not yet

Motivation / Use-Case

Fixes #2786, fixes #2760

Breaking Changes

No

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will fix CI problem today/tomorrow and merge it

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #2811 (34d2b8a) into v4 (0a6feac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2811   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files          39       39           
  Lines        1308     1309    +1     
  Branches      348      349    +1     
=======================================
+ Hits         1217     1218    +1     
  Misses         87       87           
  Partials        4        4           
Impacted Files Coverage Δ
client-src/default/overlay.js 97.05% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6feac...34d2b8a. Read the comment docs.

@alexander-akait
Copy link
Member

I think we need increase timeout in some tests

@snitin315 snitin315 closed this Nov 16, 2020
@snitin315 snitin315 reopened this Nov 16, 2020
@snitin315 snitin315 closed this Nov 16, 2020
@snitin315 snitin315 reopened this Nov 16, 2020
@alexander-akait
Copy link
Member

We need fix tests, please run it locally

@snitin315
Copy link
Member Author

I see a different test is failing each time. I will check it locally.

@ylemkimon
Copy link
Contributor

I can confirm all tests pass locally. I think we need a retry logic for flaky tests. Until then could you try closing and reopening the PR?

@alexander-akait
Copy link
Member

@ylemkimon we are try it many times, I think we need fix tests, because after this change the problem appears

@alexander-akait alexander-akait merged commit 6f5d0b6 into webpack:v4 Nov 17, 2020
@snitin315 snitin315 deleted the fix/overlay branch November 25, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants