-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: add --web-socket-server
#3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
- Coverage 95.70% 95.56% -0.15%
==========================================
Files 34 34
Lines 1280 1262 -18
Branches 369 358 -11
==========================================
- Hits 1225 1206 -19
- Misses 51 52 +1
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add some examples
Yep, or fix exiting example(s) |
I will update 👍🏻 |
d4e9e3a
to
a0da38e
Compare
Done ✅ |
Let's improve this, ideally we should use to get all arguments, but because we supported webpack v4, we need specify them, let's add test for this, fix schema and add necessary args: const webpack = require('webpack');
const schema = require('./lib/options');
console.log(webpack.cli.getArguments(schema)) |
Here fix for schema #3315, feel free to merge when it will be green and improve CLI args (should be easy) |
I think we can introduce the following in public API -
Then use these in |
@snitin315 Yes, this is the right direction, but we still support v4, so we don't have this API, we will implement it in the next major release, now I think we can copy paste them in our flags and add tests to ensure we nothing missing |
a0da38e
to
fbfc2ac
Compare
--web-socket-server
--web-socket-server
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
Add
--web-socket-server
.Breaking Changes
None
Additional Info
No