Skip to content

docs: add --web-socket-server #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2021
Merged

docs: add --web-socket-server #3300

merged 1 commit into from
Jun 8, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 16, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Add --web-socket-server.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #3300 (a0da38e) into master (ed6d27d) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head a0da38e differs from pull request most recent head fbfc2ac. Consider uploading reports for the commit fbfc2ac to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3300      +/-   ##
==========================================
- Coverage   95.70%   95.56%   -0.15%     
==========================================
  Files          34       34              
  Lines        1280     1262      -18     
  Branches      369      358      -11     
==========================================
- Hits         1225     1206      -19     
- Misses         51       52       +1     
  Partials        4        4              
Impacted Files Coverage Δ
client-src/index.js 90.56% <0.00%> (-0.51%) ⬇️
lib/utils/runOpen.js 97.36% <0.00%> (-0.14%) ⬇️
lib/Server.js 95.73% <0.00%> (-0.11%) ⬇️
lib/utils/DevServerPlugin.js 98.82% <0.00%> (-0.03%) ⬇️
lib/utils/normalizeOptions.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6d27d...fbfc2ac. Read the comment docs.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add some examples

@alexander-akait
Copy link
Member

Yep, or fix exiting example(s)

@snitin315
Copy link
Member Author

I will update 👍🏻

@snitin315
Copy link
Member Author

Done ✅

@alexander-akait
Copy link
Member

alexander-akait commented May 18, 2021

Let's improve this, ideally we should use to get all arguments, but because we supported webpack v4, we need specify them, let's add test for this, fix schema and add necessary args:

const webpack = require('webpack');
const schema = require('./lib/options');

console.log(webpack.cli.getArguments(schema))

@alexander-akait alexander-akait mentioned this pull request May 18, 2021
6 tasks
@alexander-akait
Copy link
Member

Here fix for schema #3315, feel free to merge when it will be green and improve CLI args (should be easy)

@snitin315
Copy link
Member Author

I think we can introduce the following in public API -

  • Server.getCliArguments() - return all cli-flgs,
  • Server.processArgs(args, config, values) - process args via webpack.cli.processArguments(args, config, values) .

Then use these in webpack-cli, and we can get rid of cli-flags.js in v5.

@alexander-akait
Copy link
Member

@snitin315 Yes, this is the right direction, but we still support v4, so we don't have this API, we will implement it in the next major release, now I think we can copy paste them in our flags and add tests to ensure we nothing missing

@snitin315 snitin315 mentioned this pull request May 21, 2021
6 tasks
@snitin315 snitin315 changed the title feat: add --web-socket-server docs: add --web-socket-server May 26, 2021
@snitin315 snitin315 merged commit ca36239 into master Jun 8, 2021
@snitin315 snitin315 deleted the web-socket-flag branch June 8, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants