-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: move runBonjour
and runOpen
utils to Server
#3392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3392 +/- ##
==========================================
+ Coverage 87.45% 94.35% +6.89%
==========================================
Files 9 26 +17
Lines 598 1276 +678
Branches 180 402 +222
==========================================
+ Hits 523 1204 +681
- Misses 63 66 +3
+ Partials 12 6 -6
Continue to review full report at Codecov.
|
ffe94a3
to
00344fd
Compare
c8f2d44
to
dd42d13
Compare
@snitin315 I will solve conflicts, anyway we should remove more utils, some of them we can move in normalize, some as static methods |
dd42d13
to
bf5321b
Compare
Found more cases, WIP |
@snitin315 Feel free to remove more utils, ideally we should keep only two utils after refactor:
Both will be remove in the one future PR Also because we already do many breaking change and will write migration guide, make sense to remove I think removing other utils and fake tests will be good task 👍 |
Will take care of it 👍 |
@snitin315 But let's do it in separate PR 👍 I want to merge this and continue |
Yep, lets merge this one 👍 |
For Bugs and Features; did you add new tests?
Already present.
Motivation / Use-Case
Inline utils with the server.
Breaking Changes
None
Additional Info
After this