Skip to content

refactor: move runBonjourand runOpen utils to Server #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 21, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Already present.

Motivation / Use-Case

Inline utils with the server.

Breaking Changes

None

Additional Info

After this

anshumanv
anshumanv previously approved these changes Jun 6, 2021
rishabh3112
rishabh3112 previously approved these changes Jun 7, 2021
@snitin315 snitin315 dismissed stale reviews from rishabh3112 and anshumanv via a011417 June 7, 2021 11:14
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #3392 (73679e1) into master (003c927) will increase coverage by 6.89%.
The diff coverage is 94.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3392      +/-   ##
==========================================
+ Coverage   87.45%   94.35%   +6.89%     
==========================================
  Files           9       26      +17     
  Lines         598     1276     +678     
  Branches      180      402     +222     
==========================================
+ Hits          523     1204     +681     
- Misses         63       66       +3     
+ Partials       12        6       -6     
Impacted Files Coverage Δ
client-src/index.js 83.18% <83.18%> (ø)
client-src/utils/sendMessage.js 85.71% <85.71%> (ø)
client-src/utils/reloadApp.js 86.95% <86.95%> (ø)
lib/utils/getSocketServerImplementation.js 90.47% <90.47%> (ø)
lib/servers/SockJSServer.js 90.69% <90.69%> (ø)
lib/Server.js 94.31% <94.75%> (+10.85%) ⬆️
client-src/utils/createSocketURL.js 96.42% <96.42%> (ø)
lib/utils/normalizeOptions.js 96.55% <96.55%> (ø)
lib/servers/WebsocketServer.js 97.36% <97.36%> (ø)
lib/utils/DevServerPlugin.js 97.60% <97.60%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c3d69...73679e1. Read the comment docs.

rishabh3112
rishabh3112 previously approved these changes Jun 19, 2021
@alexander-akait
Copy link
Member

@snitin315 I will solve conflicts, anyway we should remove more utils, some of them we can move in normalize, some as static methods

@alexander-akait
Copy link
Member

Found more cases, WIP

@alexander-akait
Copy link
Member

alexander-akait commented Jun 21, 2021

@snitin315 Feel free to remove more utils, ideally we should keep only two utils after refactor:

  • normalizeOptions.js (we will move this as method in future)
  • DevServerPlugin.js (will be removed when we will have plugin support here)

Both will be remove in the one future PR

Also because we already do many breaking change and will write migration guide, make sense to remove findPort.js and say in docs what you need the latest version of webpack-cli to using webpack-dev-server

I think removing other utils and fake tests will be good task 👍

@snitin315
Copy link
Member Author

Will take care of it 👍

@alexander-akait
Copy link
Member

@snitin315 But let's do it in separate PR 👍 I want to merge this and continue

@snitin315
Copy link
Member Author

Yep, lets merge this one 👍

@alexander-akait alexander-akait merged commit 0020f3e into master Jun 21, 2021
@alexander-akait alexander-akait deleted the rm-run-bonjour branch June 21, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants