Skip to content

Add watch-content-base option to Webpack-1 #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

charlespwd
Copy link
Contributor

Please check if the PR fulfills these requirements

  • An example has been added or updated in examples/ (for features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Feature

What is the current behavior? (You can also link to an open issue here)
Content-base changes, nothing happens #350

What is the new behavior?
Content-base changes, app reloads.

Does this PR introduce a breaking change?

  • No

Other information:

I want those features in webpack-1 as well :)

Fixes #350

@SpaceK33z
Copy link
Member

Hmm honestly I don't want to add features to 1.x anymore, and just want to focus on getting 1.x as stable as possible.

I would recommend to use webpack v2, but don't use the caret ^. By setting it to one version specifically it can't break suddenly (since it's still in beta).

@charlespwd
Copy link
Contributor Author

But that's the thing. Webpack 2 is in beta. Which means anyone that uses it at work won't be able to use this feature until Webpack 2 is out of beta.

@Pyrolistical
Copy link

Pyrolistical commented Oct 24, 2016

this branch isn't working for me. when I try to use this feature I get the error:
Error: ENOENT: no such file or directory, open '/Users/me/my-project/node_modules/webpack-dev-server/client/live.bundle.js'

i am using the options:
webpack-dev-server --progress --colors --inline --history-api-fallback --host 0.0.0.0 --content-base development/ --watch-content-base

@SpaceK33z
Copy link
Member

@Pyrolistical you need to run npm run prepublish.

@pelx
Copy link

pelx commented Oct 28, 2016

will it fix this problem?

Mixed Content: The page at 'https://xxxxxxx.c9users.io/' was loaded over HTTPS, but requested an insecure script 'http://xxxxx.c9users.io:3808/webpack/application.js'. This request has been blocked; the content must be served over HTTPS.

rgds

@SpaceK33z
Copy link
Member

@pelx, no, that's a different problem ;).

Closing this for reasons stated above.

It won't take long anymore for the webpack v2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants