Skip to content

npm run test => error #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aladdin-add opened this issue Mar 21, 2017 · 3 comments · Fixed by #1112
Closed

npm run test => error #1041

aladdin-add opened this issue Mar 21, 2017 · 3 comments · Fixed by #1112

Comments

@aladdin-add
Copy link

after npm install, npm run build, npm run test, I got some eslint errors:
image

Did I forget something?

@skipjack
Copy link
Collaborator

skipjack commented Apr 2, 2017

@aladdin-add good point, I believe the issue is that we're using our same eslint configuration for the markdown javascript samples as we are for the actual code running the site. There's definitely value in this but if we want to continue this process it's probably worth defining some separate, more lax, rules for the javascript within .md files.

@webpack/documentation-team any thoughts? I forget who set this up initially...

@bebraw
Copy link
Contributor

bebraw commented Apr 3, 2017

Yeah, most likely we want separate linting setups per site/content to fix this.

@skipjack skipjack self-assigned this Apr 15, 2017
@skipjack
Copy link
Collaborator

Tackling this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants