Merge code-splitting-{import,require} #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipjack
reviewed
Apr 15, 2017
antwar.config.js
Outdated
| @@ -67,6 +67,8 @@ module.exports = { | |||
| /^\.\/.*\.md$/ | |||
| ); | |||
| }, { | |||
| 'code-splitting-import': '/guides/code-splitting-import', | |||
There was a problem hiding this comment.
@simon04 is this supposed to be:
'code-splitting-import': '/guides/code-splitting-async#import'
or something similar?
There was a problem hiding this comment.
Aside from that this PR lgtm 👍
There was a problem hiding this comment.
Since the import() part starts right on the top (after a short introduction), I refrained from adding an anchor.
There was a problem hiding this comment.
yeah that makes sense but didn't you remove/rename the code-splitting-import guide? Shouldn't the redirect be to /guides/code-splitting-async?
There was a problem hiding this comment.
Ahh, right. Sure! I'll amend.
There was a problem hiding this comment.
Done. Thanks for spotting this glitch!
simon04
force-pushed
the
code-splitting-async
branch
from
feee7fc to
da6ac4e
Compare
skipjack
approved these changes
Apr 15, 2017
|
Let's go for it. Funnily we got 3 PR's on this file within 16 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and fixes #992.