Skip to content

code-splitting: add new webpack 2.4.0 features #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2017
Merged

code-splitting: add new webpack 2.4.0 features #1111

merged 1 commit into from
Apr 19, 2017

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented Apr 15, 2017

No description provided.

skipjack
skipjack approved these changes Apr 18, 2017
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we bump the version number again?

image

Or are there other things that need to be added first?

@simon04 simon04 force-pushed the code-splitting-2.4.0 branch from 52d7ecf to 9de5fd8 Compare April 18, 2017 12:23
@simon04
Copy link
Collaborator Author

simon04 commented Apr 19, 2017

IMO those are the only changes requiring an documentation update: https://github.com/webpack/webpack/releases/tag/v2.4.0

For the badge I opened #1122.

@simon04 simon04 merged commit 7485ce4 into webpack:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipjack skipjack skipjack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon04 @skipjack