Skip to content

Sidebar: show vertical bar for items w/o anchors #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2017
Merged

Sidebar: show vertical bar for items w/o anchors #1125

merged 1 commit into from
Apr 19, 2017

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented Apr 19, 2017

My visual impression is that the items "Get Started", "Installation", … are subitems to "Introduction":
2017-04-19-102956_1198x974_scrot

I tried adding gray vertical bars for items w/o anchors. Some visual tuning might be necessary:
2017-04-19-102946_1198x974_scrot

@simon04 simon04 added the UI/UX label Apr 19, 2017
@simon04 simon04 requested a review from skipjack April 19, 2017 08:35
skipjack
skipjack approved these changes Apr 19, 2017
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon04 this mis-alignment has been irking me ever since I implemented the redesign. The only solution I had was to sort those to the top (though I wasn't thrilled with that).

I really like this solution, nice work!

@skipjack skipjack merged commit ef5d784 into webpack:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipjack skipjack skipjack approved these changes

Assignees
No one assigned
Labels
UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon04 @skipjack