Add "Jump to Repository" Link #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (e.g. plugins/loaders) Break page links out to their own component to isolate the logic and styling a bit. Remove icons as their alignment and weights are a bit off. This should likely be re-visited later on as they would look better with some nice icons. Resolves #1107
simon04
approved these changes
Apr 23, 2017
|
@simon04 thanks for the review! I'll add the edit icon back in then and continue to play around with this in separate branches. I like it as well but my designer side is super frustrated by the alignment and font-weight discrepancies that I saw when trying to add an icon for the new link (for consistency). Again, something I'm fine with coming back to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1107.
This adds another link beside the "Edit..." portal on external (fetched and generated) documentation. For example, you will now see something like this on any loader or plugin page:
Also made some alignment fixes and removed the icon for now as it looked a bit off. I hope to revisit and clean up the iconography for this website at some point as it's a bit messy at the moment.