Skip to content

IgnorePlugin: Link at Plugins List Page #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

welll
Copy link
Contributor

@welll welll commented May 21, 2017

This adds the Link at Plugins List Page

Index Plugins Page:
https://webpack.js.org/plugins/

It complements #1014

@jsf-clabot
Copy link

jsf-clabot commented May 21, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ welll
❌ Wellington Soares


Wellington Soares seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor semantics change, aside from that this looks good... thanks!

@@ -19,6 +19,7 @@ webpack has a rich plugin interface. Most of the features within webpack itself
|[`DllPlugin`](/plugins/dll-plugin)|Provide means to split bundles in a way that can drastically improve build time performance.|
|[`ExtractTextWebpackPlugin`](/plugins/extract-text-webpack-plugin)|Extracts Text (CSS) from your bundles into a separate file (app.bundle.css)|
|[`HtmlWebpackPlugin`](/plugins/html-webpack-plugin)| Simplifies creation of HTML files (`index.html`) to serve your bundles|
|[`IgnorePlugin`](/plugins/ignore-plugin)| Does not include some modules in your bundles|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Excludes certain modules from output" or "Excludes certain modules from bundles" would probably sound a bit better.

@skipjack
Copy link
Collaborator

@welll thanks for making that change, can you add that other email to your account to resolve that cla-bot issue? See the comment above:

Wellington Soares seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@welll
Copy link
Contributor Author

welll commented May 22, 2017

@skipjack I made some mistakes trying to rebase/squash my commits using only my Github account. I am creating this PR again. Sorry about that.

@skipjack
Copy link
Collaborator

skipjack commented May 22, 2017

No worries just ping me when it's ready 👍

@welll welll deleted the patch-1 branch May 24, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants