docs(DevServer): document writeToDisk output dir #3305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready Built with commit bb0a922 https://deploy-preview-3305--webpackjsorg-netlify.netlify.com |
EugeneHlushko
requested changes
Oct 2, 2019
| `boolean = false` `function (filePath)` | ||
|
|
||
| Tells `devServer` to write generated assets to the disk. | ||
| Tells `devServer` to write generated assets to the disk. The output is written to the [output.path](/configuration/output/#outputpath) directory, which is `./dist` by default. |
There was a problem hiding this comment.
Please avoid duplicating defaults, we already have a link.
Suggested change
| Tells `devServer` to write generated assets to the disk. The output is written to the [output.path](/configuration/output/#outputpath) directory, which is `./dist` by default. | |
| Tells `devServer` to write generated assets to the disk. The output is written to the [output.path](/configuration/output/#outputpath) directory. |
The link to where the default is documented is sufficient.
EugeneHlushko
approved these changes
Oct 6, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell users of
DevServer.writeToDiskwhere to find the output that gets written to disk.fixes #3304