docs(concepts) loaders command fix and message re-worked #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready Built with commit bf15051 https://deploy-preview-3311--webpackjsorg-netlify.netlify.com |
montogeek
reviewed
Oct 10, 2019
| @@ -25,8 +25,7 @@ Loaders are transformations that are applied on the source code of a module. The | |||
| For example, you can use loaders to tell webpack to load a CSS file or to convert TypeScript to JavaScript. To do this, you would start by installing the loaders you need: | |||
|
|
|||
| ``` bash | |||
| npm install --save-dev css-loader | |||
| npm install --save-dev ts-loader | |||
| npm install --save-dev css-loader ts-loader | |||
There was a problem hiding this comment.
Do we have more cases like this one?
There was a problem hiding this comment.
Just quickly checked guides section, looks like we have a few there and maybe more. I will create a follow-up PR to change those occurrences
There was a problem hiding this comment.
In the recent years breaking work down and keeping it isolated and focused helped a lot to move quicker, did not you notice? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm install command wasnt running without
&¬ation so it makes sense to merge it.The loaders ecosystem empowerment phrase was not backed up nor it wasn't straightforward, reworded it