Fix user config options not being applied when they are imported from an es6 module with babel6 #2376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👉 Friendly poke! Let me know if you need any changes. |
sokra
added a commit
that referenced
this pull request
May 5, 2016
i. e. when passing a es6 module like #2376
|
Any chance this can get merged? I keep having to patch it locally. Let me know if there is anything I need to do! |
Current coverage is 83.64%@@ master #2376 diff @@
=======================================
Files 231 229 -2
Lines 9088 8775 -313
Methods 1660 0 -1660
Branches 1808 1698 -110
=======================================
- Hits 8283 7340 -943
- Misses 805 887 +82
- Partials 0 548 +548
|
… an es6 module with babel 6
|
🔔 Ping. |
|
@sokra anything I need to do here? |
1 similar comment
|
@sokra anything I need to do here? |
|
I'll not merge it. It not the job of the webpack node.js API to care for modules. It just expects a options object (not a module). The CLI care for the module loading and it takes care of ES6 modules. If using the node.js API you need to care for module loading yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug exists in webpack1 and webpack2. This patch is against master, let me know if you want me to backport. As people upgrade to babel 6 more and more are going to hit it...
Bug could manifest in two ways:
invalid argument pathToArrayerror. This happens because the default foroutput.pathis""in webpack1webpack()returning super early but no errors thrown and no bundles created. This happens because the default foroutput.pathiscwd(). Note: it works from the command line because the check was already there in the CLI parsing code, just not the node API.This bug caused my working webpack config with babel5 to fail when upgrading to babel6. This was mainly due to my custom
output.pathbeing overwritten, so maybe other errors manifest differently than above. Also note the webpack1 error I got is hard to google...it usually is a symptom of people not putting in absolute paths tooutput.path...but in this case it is specified and webpack overwrites it as mentioned above.This took me way too long to debug, mainly because there is a lot of indirection and the webpack
Optionshave the concept of a "default" that isn't the same as an ES6 default of course! 🔎