-
-
Notifications
You must be signed in to change notification settings - Fork 57
Update superadmin quota dialog with relative changes & presets #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
updates the org quota editor to allow both adjustment values and direct value editing for quotas other than additional/gifted execution minutes
3663e35
to
caeceb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We may move the plans to a separate configmap/secret later, but this should be good for now!
Have you tried a dropdown for presets? I personally find it easier to interact with than long button groups, it wasn't immediately clear to me that it can scroll horizontally. |
That's not a bad idea! I did want to have a bunch of the options visible initially, but I think you might be right, especially with the number of plans we've got currently. I'll give it a go! |
Closes #2824
Changes
min
,max
, andstep
props fornumber
input types)available_plans
to a JSON string matching thePlansResponse
object type. If unset, the presets section will show a single "unset" preset.Testing
This should be tested with both frontend and backend deployed with these changes, so you might want to test locally or deploy to dev.
Screenshots
Testing
All tested locally against dev.
Footnotes
We're pretty limited by Lit's lack of support for generics in element types, so there's a few errors from lit-analyzer that are a little tricky to get around, but iirc work is being done to get closer to this! So we might not need to switch to JSX for this to be supportable in the future. ↩