Simplify server JSON handler code for RPC methods #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
force-pushed
the
simplify_method_handler
branch
from
6c6c3f9 to
3134536
Compare
VojtechVitek
force-pushed
the
simplify_method_handler
branch
from
3134536 to
f3a2c65
Compare
No need to define defer-panic in JSON handler for each generated RPC method, since the generated Go methods are private and called only from within .ServerHTTP().
VojtechVitek
commented
Aug 25, 2023
| RespondWithError(w, ErrorWithCause(ErrWebrpcServerPanic, fmt.Errorf("%v", rr))) | ||
| panic(rr) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Move the defer-panic up to the ServeHTTP() method.
No need to define defer-panic in JSON handler for each generated RPC method, since the generated Go methods are private and called only from within .ServerHTTP().
VojtechVitek
commented
Aug 25, 2023
| panic(rr) | ||
| } | ||
| }() | ||
| ret0, err = s.ExampleService.Status(ctx) |
There was a problem hiding this comment.
Move the service call to the main handler function. Remove the unnecessarry anonymous function and a defer call (which was moved up to the parent .ServeHTTP() method)
Merged
VojtechVitek
added a commit
to golang-cz/webrpc
that referenced
this pull request
Aug 25, 2023
VojtechVitek
added a commit
to webrpc/webrpc
that referenced
this pull request
Aug 25, 2023
darkhorse0311
added a commit
to darkhorse0311/WebRPC
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.