-
Notifications
You must be signed in to change notification settings - Fork 5.8k
audio: use replaceTrack for "hard" mute #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
uses replaceTrack for hard muting. This is different from soft mute, i.e. setting track.enabled = false
so in the "stage 2" model there is an issue. Suppose I have an audio/video connection. Then I replace both the audio and the video track with null. In the transceiver model this is pretty easy to solve. Iterate over getTransceivers(), find the sender where track is null and the receivers track.kind is audio. Stuck in the middle. |
I'm against this, because:
The samples should help guide people to using the spec, not work around Chrome bugs. I don't see that the "soft"/"hard" distinction serves any other purpose here. The fourth point is important to us at Mozilla, because Firefox 60 now implements turning off the camera on mute, a key step to getting sites like Hangouts to stop using
This is a Chrome issue IMHO. Spec now says: "In the case of video, the RTCRtpSender SHOULD send one black frame per second." |
@jan-ivar i think you're more opposed to #996 then which shows that technique. But we need some way to QA this and doing it here where we have both @KaptenJansson+crew and the general public prod at it... |
I suggest storing them as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed the discussion on this issue...
probably move this stuff to https://github.com/webrtc/test-pages |
based on pc1 sample and the following two PRs: webrtc/samples#1009 webrtc/samples#996
Description
uses replaceTrack for hard muting. This is different from soft mute, i.e. setting track.enabled = false
which (in chrome) continues to send 50 packets/s at a slightly lower bitrate
Purpose
I want to use replaceTrack(null) so I would like to see some basic QA :-)
@henbos PTAL since you wanted this as well.
@KaptenJansson wdyt about adding "QA" instructions on the page?
@jan-ivar replaceTrack(null) is only supported in 59+, right? Graphs freeze after replaceTrack(null), afaics getStats() does not return any rtp stats?