Update native-tls and tokio-tls #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vi
reviewed
Sep 23, 2018
| Err(e) => return Box::new(future::err(e)), | ||
| } | ||
| }; | ||
| // secure connection, wrap with ssl | ||
| let future = tcp_stream | ||
| .map_err(|e| e.into()) | ||
| .and_then(move |s| connector.connect_async(&host, s).map_err(|e| e.into())) | ||
| .and_then(move |s| connector.connect(&host, s).map_err(|e| e.into())) |
There was a problem hiding this comment.
Is it still async connect, not the blocking version?
|
Which version should it be after this pull request: |
It requires upgrading |
|
Ping |
|
I have a reminder to check accumulated pull requests and make a rust-websocket release in 20 days, in case of inactivity of original developers of rust-websocket. |
Bobo1239
added a commit
to Bobo1239/cargo-web
that referenced
this pull request
Oct 18, 2018
Bobo1239
added a commit
to Bobo1239/cargo-web
that referenced
this pull request
Oct 18, 2018
Bobo1239
added a commit
to Bobo1239/cargo-web
that referenced
this pull request
Oct 18, 2018
This was referenced Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native-tls 0.1 uses outdated
opensslcrate that doesn't build with OpenSSL 1.1.1 (Arch Linux is already using it and openSUSE Tumbleweed will update in a few days).Updating native-tls also fixes few issues with static OpenSSL builds.
It throws warnings like:
But I couldn't manage to fix them.