Skip to content

Add multitask 3.18 tsvs to datasets in Makefile #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lizgzil
Copy link
Contributor

@lizgzil lizgzil commented Apr 2, 2020

Fixes #29

Copy link
Contributor

@ivyleavedtoadflax ivyleavedtoadflax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ivyleavedtoadflax ivyleavedtoadflax changed the base branch from master to feature/ivyleavedtoadflax/multitask_2 April 3, 2020 03:26
@ivyleavedtoadflax
Copy link
Contributor

Btw I changed the base on this to point to the multitask branch, it wouldn't make sense to merge this into master just yet.

The `2020.3.19_multitask` model will replace `2020.3.18` as the default model.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/ivyleavedtoadflax/multitask_2@fbc37d1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                            @@
##             feature/ivyleavedtoadflax/multitask_2      #30   +/-   ##
========================================================================
  Coverage                                         ?   83.75%           
========================================================================
  Files                                            ?       16           
  Lines                                            ?     1200           
  Branches                                         ?        0           
========================================================================
  Hits                                             ?     1005           
  Misses                                           ?      195           
  Partials                                         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc37d1...1be3864. Read the comment docs.

@ivyleavedtoadflax ivyleavedtoadflax merged commit 88f1a24 into feature/ivyleavedtoadflax/multitask_2 Apr 12, 2020
@ivyleavedtoadflax ivyleavedtoadflax deleted the add-multitask-makefile branch April 12, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multitask data to Makefile
3 participants