Skip to content

Pinning keras and tensorflow versions in setup #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

lizgzil
Copy link
Contributor

@lizgzil lizgzil commented Aug 6, 2020

The new Keras version 2.4.0 released in June 2020 made changes that broke the deep reference parser.

 File "/usr/local/lib/python3.6/site-packages/deep_reference_parser/deep_reference_parser.py", line 989, in load_weights
    saving.load_weights_from_hdf5_group(

AttributeError: module 'keras.engine.saving' has no attribute 'load_weights_from_hdf5_group'

Thus I've pinned the version of keras to 2.2.5 (which is whats in the requirements). I also needed to pin the version of keras-contrib since it overwrote keras 2.2.5 to the newer version. Then I got issues with tensorflow, so also pinned this to the version in the requirements.

@codecov-commenter
Copy link

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   81.46%   81.46%           
=======================================
  Files          17       17           
  Lines        1338     1338           
=======================================
  Hits         1090     1090           
  Misses        248      248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85949cb...51b5912. Read the comment docs.

@ivyleavedtoadflax
Copy link
Contributor

Makes sense @lizgzil 👍 Long term i think it would be worth moving to tf.keras with tf 2.0, what prevented me in the past was that CRFs were not implemented, but it looks like they have been added now: tensorflow/addons#1999

@ivyleavedtoadflax
Copy link
Contributor

Also referenced here: #28

@lizgzil lizgzil merged commit d3944aa into master Aug 19, 2020
@lizgzil lizgzil deleted the pin-versions branch August 19, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants