Skip to content

feat: tweak proof submitter logic #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: tweak proof submitter logic #2639

merged 1 commit into from
Aug 22, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Aug 22, 2024


PR-Codex overview

This PR tweaks the proof submitter logic in the OP Stack module.

Detailed summary

  • Updated logic for retrieving proof submitter based on the number of proof submitters
  • Improved error handling for fetching proof submitter
  • Adjusted arguments for reading contract function to fetch proof submitter

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Aug 22, 2024 0:43am

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 167fc2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 60.33 KB (0%) 1.3 s (0%) 493 ms (-48.68% 🔽) 1.7 s
const viem = require('viem') (cjs) 71 KB (0%) 1.5 s (0%) 395 ms (-51.1% 🔽) 1.9 s
import { createClient, http } from 'viem' 6.22 KB (0%) 125 ms (0%) 96 ms (+129.13% 🔺) 220 ms
import * from 'viem/account-abstraction' 43.7 KB (0%) 874 ms (0%) 556 ms (+56.25% 🔺) 1.5 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 33.91 KB (0%) 679 ms (0%) 627 ms (+149.97% 🔺) 1.4 s
import * from 'viem/accounts' 74.61 KB (0%) 1.5 s (0%) 342 ms (+7.48% 🔺) 1.9 s
import { privateKeyToAccount } from 'viem/accounts' 19.37 KB (0%) 388 ms (0%) 95 ms (-40.59% 🔽) 483 ms
import * from 'viem/actions' 45.9 KB (0%) 919 ms (0%) 263 ms (-42.19% 🔽) 1.2 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 3 ms (-89.04% 🔽) 13 ms
import * from 'viem/chains' 31.09 KB (0%) 622 ms (0%) 267 ms (-9.83% 🔽) 889 ms
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 27 ms (+413.34% 🔺) 37 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 5 ms (+76.99% 🔺) 26 ms
import * from 'viem/ens' 45.45 KB (0%) 909 ms (0%) 253 ms (+117.91% 🔺) 1.2 s
import { getEnsAvatar } from 'viem/ens' 22.13 KB (0%) 443 ms (0%) 242 ms (+49.49% 🔺) 684 ms
import * from 'viem/siwe' 30.23 KB (0%) 605 ms (0%) 343 ms (-3.11% 🔽) 948 ms
import { verifySiweMessage } from 'viem/siwe' 29.17 KB (0%) 584 ms (0%) 229 ms (+23.37% 🔺) 812 ms

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 99.64%. Comparing base (f383a8e) to head (167fc2a).
Report is 1 commits behind head on main.

Files Patch % Lines
src/op-stack/actions/getTimeToFinalize.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
- Coverage   99.67%   99.64%   -0.03%     
==========================================
  Files         777      777              
  Lines       70293    70307      +14     
  Branches     3276     3275       -1     
==========================================
- Hits        70062    70060       -2     
- Misses        217      232      +15     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom merged commit 9a1c6ab into main Aug 22, 2024
28 of 36 checks passed
@jxom jxom deleted the jxom/proof-submitter branch August 22, 2024 01:26
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
@tmm tmm mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant