-
-
Notifications
You must be signed in to change notification settings - Fork 292
Fix/app performance #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abhisheksainii
wants to merge
6
commits into
wger-project:master
Choose a base branch
from
Abhisheksainii:fix/app-performance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/app performance #444
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
df45bd4
app performance related issues fixes
Abhisheksainii 5ebbbe5
app performance related issues fixes
Abhisheksainii d19c305
Merge branch 'fix/app-performance' of https://github.com/Abhisheksain…
Abhisheksainii 5f4bbb0
Merge branch 'master' into fix/app-performance
Abhisheksainii 66646c0
Merge branch 'master' into fix/app-performance
Abhisheksainii 337d83c
fix(common): removal of const and regeneration of pubspec.lock file
Abhisheksainii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,53 +74,53 @@ class _HomeTabsScreenState extends State<HomeTabsScreen> with SingleTickerProvid | |
final authProvider = context.read<AuthProvider>(); | ||
|
||
if (!authProvider.dataInit) { | ||
final workoutPlansProvider = context.read<WorkoutPlansProvider>(); | ||
final nutritionPlansProvider = context.read<NutritionPlansProvider>(); | ||
final exercisesProvider = context.read<ExercisesProvider>(); | ||
final galleryProvider = context.read<GalleryProvider>(); | ||
final weightProvider = context.read<BodyWeightProvider>(); | ||
final measurementProvider = context.read<MeasurementProvider>(); | ||
final userProvider = context.read<UserProvider>(); | ||
// final workoutPlansProvider = context.read<WorkoutPlansProvider>(); | ||
// final nutritionPlansProvider = context.read<NutritionPlansProvider>(); | ||
// final exercisesProvider = context.read<ExercisesProvider>(); | ||
// final galleryProvider = context.read<GalleryProvider>(); | ||
|
||
// final userProvider = context.read<UserProvider>(); | ||
|
||
// Base data | ||
log('Loading base data'); | ||
try { | ||
await Future.wait([ | ||
authProvider.setServerVersion(), | ||
userProvider.fetchAndSetProfile(), | ||
workoutPlansProvider.fetchAndSetUnits(), | ||
nutritionPlansProvider.fetchIngredientsFromCache(), | ||
exercisesProvider.fetchAndSetExercises(), | ||
context.read<UserProvider>().fetchAndSetProfile(), | ||
context.read<WorkoutPlansProvider>().fetchAndSetUnits(), | ||
context.read<NutritionPlansProvider>().fetchIngredientsFromCache(), | ||
context.read<ExercisesProvider>().fetchAndSetExercises(), | ||
context.read<GalleryProvider>().fetchAndSetGallery(), | ||
]); | ||
} catch (e) { | ||
log('fire! fire!'); | ||
log(e.toString()); | ||
} | ||
|
||
// Plans, weight and gallery | ||
log('Loading plans, weight, measurements and gallery'); | ||
await Future.wait([ | ||
galleryProvider.fetchAndSetGallery(), | ||
nutritionPlansProvider.fetchAndSetAllPlansSparse(), | ||
workoutPlansProvider.fetchAndSetAllPlansSparse(), | ||
weightProvider.fetchAndSetEntries(), | ||
measurementProvider.fetchAndSetAllCategoriesAndEntries(), | ||
]); | ||
// log('Loading plans, weight, measurements and gallery'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove commented out code if not going to be used (see prev comment). |
||
// await Future.wait([ | ||
// galleryProvider.fetchAndSetGallery(), | ||
// nutritionPlansProvider.fetchAndSetAllPlansSparse(), | ||
// workoutPlansProvider.fetchAndSetAllPlansSparse(), | ||
// weightProvider.fetchAndSetEntries(), | ||
// measurementProvider.fetchAndSetAllCategoriesAndEntries(), | ||
// ]); | ||
|
||
// Current nutritional plan | ||
log('Loading current nutritional plan'); | ||
if (nutritionPlansProvider.currentPlan != null) { | ||
final plan = nutritionPlansProvider.currentPlan!; | ||
await nutritionPlansProvider.fetchAndSetPlanFull(plan.id!); | ||
} | ||
|
||
// Current workout plan | ||
log('Loading current workout plan'); | ||
if (workoutPlansProvider.activePlan != null) { | ||
final planId = workoutPlansProvider.activePlan!.id!; | ||
await workoutPlansProvider.fetchAndSetWorkoutPlanFull(planId); | ||
workoutPlansProvider.setCurrentPlan(planId); | ||
} | ||
// log('Loading current nutritional plan'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove (see prev comment) |
||
// if (nutritionPlansProvider.currentPlan != null) { | ||
// final plan = nutritionPlansProvider.currentPlan!; | ||
// await nutritionPlansProvider.fetchAndSetPlanFull(plan.id!); | ||
// } | ||
|
||
// // Current workout plan | ||
// log('Loading current workout plan'); | ||
// if (workoutPlansProvider.activePlan != null) { | ||
// final planId = workoutPlansProvider.activePlan!.id!; | ||
// await workoutPlansProvider.fetchAndSetWorkoutPlanFull(planId); | ||
// workoutPlansProvider.setCurrentPlan(planId); | ||
// } | ||
} | ||
|
||
authProvider.dataInit = true; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should ideally be removed if now unused.