Add more legacy event types for createEvent() #220
Conversation
Approximately as requested at <https://bugzilla.mozilla.org/show_bug.cgi?id=1251198#c7>. This is the list of events supported in createEvent() by at least two of Firefox, Chrome, and IE 11. The one exception is I omitted MutationEvent, which all three support, because apparently spec-land has decided to deny its existence in the hope that it will go away. XXX Bikeshed does not know about all of the added interface names and I don't know how to tell it. (The error is non-fatal, they just aren't linked.)
| <tr><td>"<code>htmlevents</code>" | ||
| <tr><td>"<code>focusevent</code>"<td>{{FocusEvent}}<td>[[!UIEVENTS]] | ||
| <tr><td>"<code>hashchangeevent</code>"<td>{{HashChangeEvent}}<td>[[!HTML]] | ||
| <tr><td>"<code>htmlevents</code>"<td>{{Event}}<td> |
There was a problem hiding this comment.
I think it would be clearer to keep this grouped with "event" and "events" and ignore it for sorting purposes. Same for "svgevent" below, didn't know that was a thing. Sad times.
There was a problem hiding this comment.
I considered that, but decided it would be confusing if the reader were trying to check if an event is on the list, and that that outweighs the benefit.
There was a problem hiding this comment.
Though, maybe note that in the source somehow, so that folks don't try to patch it up.
|
Chrome supports some of them when we use CamelCase notation. DragEvent: Firefox, Chrome, IE11, Presto CompositionEvent: Firefox, Chrome, IE11 BeforeUnloadEvent: Firefox, Chrome |
|
I didn't notice that Chrome and IE return TextEvent -- thanks! But there's no such thing as TextEvent right now in standards-land, and it doesn't seem worth it to define it just for this. So we don't otherwise want to define it, Chrome and IE should get rid of it and return CompositionEvent like Firefox. Is there anything else in your comment that differs from the commit? It looks like all the events you mentioned are already in the changeset. |
|
No, all ok, comments deceived me and I don't looked for a new list. |
|
Also, thank you for cleaning this up! |
|
@annevk What makes it cleaner if I create branches directly on the repository? |
|
(Also, I don't think I have write permissions to the whatwg repositories. It says I don't have the rights to merge pull requests, and once when I tried pushing by accident to the whatwg repo instead of my own, I got a permissions error.) |
|
@ayg it makes it possible for me to push fixups to the branch and then merge the PR in a way that GitHub understands it as merged and therefore it will link back to it from the commit that ends up on master, giving the repository a bit more history without having to manually add a PR link to the commit. Push access to master is restricted, but you should have write access for this repository meaning you can create branches and such. Let me know if you need access to other repositories. |
Approximately as requested at
https://bugzilla.mozilla.org/show_bug.cgi?id=1251198#c7. This is the
list of events supported in createEvent() by at least two of Firefox,
Chrome, and IE 11. The one exception is I omitted MutationEvent, which
all three support, because apparently spec-land has decided to deny its
existence in the hope that it will go away.
XXX Bikeshed does not know about all of the added interface names and I
don't know how to tell it. (The error is non-fatal, they just aren't
linked.)