Editorial: align with new IDL patterns #1054
Conversation
Use "this" and "x steps are". Also use the relevant settings object in constructors, rather than current. (They are identical there, but it's better to encourage relevant.)
| </ol> | ||
|
|
||
| <p>The static <dfn method for=Response><code>error()</code></dfn> method, when invoked, must run | ||
| these steps: | ||
| <p>The static <dfn method for=Response><code>error()</code></dfn> method steps are: | ||
|
|
||
| <ol> | ||
| <li><p>Let <var>r</var> be a new {{Response}} object, whose <a for=Response>response</a> is a new |
There was a problem hiding this comment.
This could link to https://heycam.github.io/webidl/#new and state the realm (current realm).
There are a total of 6 nearby object creations that could do the same.
| @@ -6841,14 +6799,14 @@ partial interface mixin WindowOrWorkerGlobalScope { | |||
|
|
|||
| <p>The | |||
| <dfn id=dom-global-fetch method for=WindowOrWorkerGlobalScope><code>fetch(<var>input</var>, <var>init</var>)</code></dfn> | |||
| method, must run these steps: | |||
| method steps are: | |||
|
|
|||
| <ol> | |||
| <li><p>Let <var>p</var> be a new promise. | |||
There was a problem hiding this comment.
This could be [=a new promise=], although then you should specify the realm; I'd be curious whether it's relevant or current in implementations...
| @@ -6841,14 +6799,14 @@ partial interface mixin WindowOrWorkerGlobalScope { | |||
|
|
|||
| <p>The | |||
| <dfn id=dom-global-fetch method for=WindowOrWorkerGlobalScope><code>fetch(<var>input</var>, <var>init</var>)</code></dfn> | |||
| method, must run these steps: | |||
| method steps are: | |||
There was a problem hiding this comment.
The object construction in here is pretty sketchy, but I imagine you're aware already, and any solutions would probably be larger diffs than makes sense for this PR.
There was a problem hiding this comment.
Yeah, there's a number of places where we don't specify realms and I basically need to write tests. But I also want that to be separate as it's no longer editorial.
|
Anything else to be done here? |
|
LGTM |
Use "this" and "x steps are". Also use the relevant settings object in constructors, rather than current. (They are identical there, but it's better to encourage relevant.)
Preview | Diff