Add initStorageEvent() #4063
Merged
Add initStorageEvent() #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Oct 4, 2018
| @@ -93990,7 +93990,7 @@ typedef (<span>WindowProxy</span> or <span>MessagePort</span> or <span>ServiceWo | |||
| value it was initialized to. It represents, in <span>cross-document messaging</span> and | |||
| <span>channel messaging</span>, the <code>MessagePort</code> array being sent.</p> | |||
|
|
|||
| <!-- handwave this one since it's deprecated anyway... let me know if there's interop issues --> | |||
| <!-- handwavy, file bugs if there are interop issues --> | |||
There was a problem hiding this comment.
We could use https://dom.spec.whatwg.org/#dom-customevent-initcustomevent as a template, though maybe we should wait until we have internal slots.
There was a problem hiding this comment.
https://dom.spec.whatwg.org/#dom-customevent-detail isn't an internal slot, so the same pattern could be followed.
I think some analogue to https://dom.spec.whatwg.org/#inner-event-creation-steps might work here, but there aren't that many initFooEvent and for all practical purposes I think handwaving plus tests will be enough.
I can do some cleanup though, if you have a specific setup you'd like.
There was a problem hiding this comment.
I think I'd prefer waiting until we have internal slots, since what initCustomEvent() does isn't quite right either.
There was a problem hiding this comment.
All right, this and the tests are ready for review, then. See web-platform-tests/wpt#13368 (comment) for current behavior.
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 4, 2018
Tests: web-platform-tests/wpt#13368 Fixes #1054.
foolip
force-pushed
the
foolip/initStorageEvent
branch
from
764e269 to
df9d721
Compare
annevk
approved these changes
Oct 5, 2018
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 5, 2018
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 5, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 12, 2018
…orageEvent(), a=testonly Automatic update from web-platform-testsTest initStorageEvent() Follows whatwg/html#4063. -- Consolidate/simplify StorageEvent constructor tests The use of `async_test` was already unnecessary as `dispatchEvent` synchronously invokes listeners, and use of `dispatcEvent` itself is not necessary to test the constructor, so simplify to just `test`s. -- wpt-commits: c4fce5c3c37e30b192a596c4dc779e4192f1bc12, bd5f3403f34f8e83eecbdc172cd330039e12ab86 wpt-pr: 13368
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Oct 15, 2018
…orageEvent(), a=testonly Automatic update from web-platform-testsTest initStorageEvent() Follows whatwg/html#4063. -- Consolidate/simplify StorageEvent constructor tests The use of `async_test` was already unnecessary as `dispatchEvent` synchronously invokes listeners, and use of `dispatcEvent` itself is not necessary to test the constructor, so simplify to just `test`s. -- wpt-commits: c4fce5c3c37e30b192a596c4dc779e4192f1bc12, bd5f3403f34f8e83eecbdc172cd330039e12ab86 wpt-pr: 13368
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 16, 2019
initStorageEvent was standardized in whatwg/html#4063. spec: https://html.spec.whatwg.org/multipage/webstorage.html#the-storageevent-interface Bug: 697170 Change-Id: Ie08062686c82c22a068546e74ec89cbebf65afc8 Reviewed-on: https://chromium-review.googlesource.com/c/1411752 Reviewed-by: Joshua Bell <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Commit-Queue: Amos Lim <[email protected]> Cr-Commit-Position: refs/heads/master@{#623013}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…orageEvent(), a=testonly Automatic update from web-platform-testsTest initStorageEvent() Follows whatwg/html#4063. -- Consolidate/simplify StorageEvent constructor tests The use of `async_test` was already unnecessary as `dispatchEvent` synchronously invokes listeners, and use of `dispatcEvent` itself is not necessary to test the constructor, so simplify to just `test`s. -- wpt-commits: c4fce5c3c37e30b192a596c4dc779e4192f1bc12, bd5f3403f34f8e83eecbdc172cd330039e12ab86 wpt-pr: 13368 UltraBlame original commit: e726946c50a836304adcf437ca93290e061e2a71
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…orageEvent(), a=testonly Automatic update from web-platform-testsTest initStorageEvent() Follows whatwg/html#4063. -- Consolidate/simplify StorageEvent constructor tests The use of `async_test` was already unnecessary as `dispatchEvent` synchronously invokes listeners, and use of `dispatcEvent` itself is not necessary to test the constructor, so simplify to just `test`s. -- wpt-commits: c4fce5c3c37e30b192a596c4dc779e4192f1bc12, bd5f3403f34f8e83eecbdc172cd330039e12ab86 wpt-pr: 13368 UltraBlame original commit: e726946c50a836304adcf437ca93290e061e2a71
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…orageEvent(), a=testonly Automatic update from web-platform-testsTest initStorageEvent() Follows whatwg/html#4063. -- Consolidate/simplify StorageEvent constructor tests The use of `async_test` was already unnecessary as `dispatchEvent` synchronously invokes listeners, and use of `dispatcEvent` itself is not necessary to test the constructor, so simplify to just `test`s. -- wpt-commits: c4fce5c3c37e30b192a596c4dc779e4192f1bc12, bd5f3403f34f8e83eecbdc172cd330039e12ab86 wpt-pr: 13368 UltraBlame original commit: e726946c50a836304adcf437ca93290e061e2a71
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…orageEvent(), a=testonly Automatic update from web-platform-testsTest initStorageEvent() Follows whatwg/html#4063. -- Consolidate/simplify StorageEvent constructor tests The use of `async_test` was already unnecessary as `dispatchEvent` synchronously invokes listeners, and use of `dispatcEvent` itself is not necessary to test the constructor, so simplify to just `test`s. -- wpt-commits: c4fce5c3c37e30b192a596c4dc779e4192f1bc12, bd5f3403f34f8e83eecbdc172cd330039e12ab86 wpt-pr: 13368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#13368
Fixes #1054.
/webstorage.html ( diff )