Add popover open check in attribute change steps #9526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes whatwg#9459 Chromium has already had this check for some time, and without it firefox hits an assertion: whatwg#9459
This was referenced Jul 17, 2023
|
Firfox will introduce this check at https://phabricator.services.mozilla.com/D181880. Thanks @josepharhar! |
4 tasks
ghost
reviewed
Jul 18, 2023
| <li><p>If <var>oldValue</var> and <var>value</var> are in different <span | ||
| data-x="attr-popover">states</span>, then run the <span>hide popover algorithm</span> given | ||
| <var>element</var>, true, true, and false.</p></li> | ||
| <li><p>If <var>element</var>'s <span>popover visibility state</span> is in the <span |
There was a problem hiding this comment.
The change proposed in #9459 (comment) is slightly different. Was the second check skip intentionally?
There was a problem hiding this comment.
Ah, yeah I see you mentioned checking the popover showing or hiding flag.
Does your jsfiddle from this comment show why checking the popover showing or hiding flag helps?
There was a problem hiding this comment.
@josepharhar: sorry, due to the complexity of the topic and lack of time I currently can't answer that question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9459
Chromium has already had this check for some time, and without it firefox hits an assertion:
#9459
(See WHATWG Working Mode: Changes for more details.)
/popover.html ( diff )