Skip to content

Editorial: use Type(x) where appropriate. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2017
Merged

Editorial: use Type(x) where appropriate. #270

merged 2 commits into from
Jan 20, 2017

Conversation

tobie
Copy link
Collaborator

@tobie tobie commented Jan 20, 2017 •
edited
Loading

@domenic
Copy link
Member

domenic commented Jan 20, 2017

Changes LGTM. Some additional possibilities:

Also there's a lot of "x is an object that implements interface I" but we can leave those alone for now since the more important part of making them precise is covered by #97.

@domenic
Copy link
Member

domenic commented Jan 20, 2017

Oh, also the commit message should use "where" instead of "were" :)

@tobie
Copy link
Collaborator Author

tobie commented Jan 20, 2017

Witch commit message? ;)

@tobie tobie merged commit 898b8d2 into whatwg:gh-pages Jan 20, 2017
@tobie tobie deleted the fix-222 branch January 20, 2017 20:13
@tobie tobie mentioned this pull request Jan 20, 2017
Closed
@tobie tobie changed the title Editorial: use Type(x) were appropriate. Editorial: use Type(x) where appropriate. Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobie @domenic