Update SessionManager example #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobie
reviewed
Aug 22, 2017
index.bs
Outdated
| @@ -3460,7 +3457,9 @@ interfaces that have interface members with these names. | |||
|
|
|||
| typeof SessionManager.prototype.values; // Evaluates to "function" | |||
| var it = sm.values(); // values() returns an iterator object | |||
| String(it); // Evaluates to "[object SessionManager Iterator]" | |||
| String(it); // Evaluates to "[object SessionManagerIterator]" | |||
There was a problem hiding this comment.
I don't think we should change this now. Maybe comment out the whole thing?
index.bs
Outdated
| and [index, session object] pairs, respectively. It also has | ||
| next value to be iterated over. It has <code>keys</code> and <code>entries</code> | ||
| methods that iterate over the usernames of session objects | ||
| and [username, Session object] pairs, respectively. It also has |
There was a problem hiding this comment.
Can you use the tuple/pair notation from infra here (either (username, Session object) or username/Session object)?
tobie
reviewed
Aug 24, 2017
index.bs
Outdated
| @@ -3460,7 +3457,8 @@ interfaces that have interface members with these names. | |||
|
|
|||
| typeof SessionManager.prototype.values; // Evaluates to "function" | |||
| var it = sm.values(); // values() returns an iterator object | |||
| String(it); // Evaluates to "[object SessionManager Iterator]" | |||
| <!-- String(it); // Evaluates to "[object SessionManagerIterator]" | |||
| // TODO: https://github.com/heycam/webidl/issues/419 --> | |||
| typeof it.next; // Evaluates to "function" | |||
|
|
|||
| // This loop will alert "anna" and then "brian". | |||
There was a problem hiding this comment.
Sorry I didn't notice that before, can you change this to "log" stuff rather than "alert" it?
So s/This loop will also alert/This loop will also log/ and s/window.alert/console.log/.
tobie
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be happy to update the class string once #419 is resolved, but submitting this for review first.
Preview | Diff