Skip to content

Add an algorithm to create a platform object. #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add an algorithm to create a platform object. #635

merged 1 commit into from
Feb 22, 2019

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Jan 31, 2019 •
edited by pr-preview bot
Loading

@Ms2ger
Copy link
Member Author

Ms2ger commented Jan 31, 2019

This is partially based on the algorithm in #595, and there's still a bunch of declarative requirements that could move into this, but I wanted to take small steps.

annevk
annevk reviewed Jan 31, 2019
View reviewed changes
Ms2ger
Ms2ger commented Feb 7, 2019
View reviewed changes
littledan
littledan reviewed Feb 7, 2019
View reviewed changes
domenic
domenic reviewed Feb 7, 2019
View reviewed changes
This was referenced Feb 7, 2019
Closed
Closed
Ms2ger
Ms2ger commented Feb 11, 2019
View reviewed changes
domenic
domenic reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, woohoo.

domenic
domenic approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to say LGTM, although indeed "this" instead of "this value" would probably be good. We can fix that up as part of the follow-up mentioned, though.

TimothyGu
TimothyGu reviewed Feb 13, 2019
View reviewed changes
TimothyGu
TimothyGu reviewed Feb 14, 2019
View reviewed changes
bzbarsky
bzbarsky requested changes Feb 14, 2019
View reviewed changes
@Ms2ger Ms2ger mentioned this pull request Feb 20, 2019
Merged
@bzbarsky
Copy link
Collaborator

Note that this doesn't match Gecko if NewTarget has a prototype property that isn't an object.

Yep, Gecko doesn't have access to a thing that implements the per-spec behavior of GetFunctionRealm, for example. See https://bugzilla.mozilla.org/show_bug.cgi?id=1529757 and https://bugzilla.mozilla.org/show_bug.cgi?id=1317658

domenic
domenic approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please land!

@Ms2ger Ms2ger merged commit 8e1b529 into master Feb 22, 2019
@Ms2ger Ms2ger deleted the create-object branch February 22, 2019 14:04
@domenic domenic mentioned this pull request Feb 25, 2019
Open
@Ms2ger Ms2ger mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledan littledan littledan left review comments

@TimothyGu TimothyGu TimothyGu left review comments

@annevk annevk annevk left review comments

@yuki3 yuki3 yuki3 left review comments

@domenic domenic domenic approved these changes

@bzbarsky bzbarsky bzbarsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ms2ger @bzbarsky @littledan @domenic @TimothyGu @annevk @yuki3