More fixes for undefined
#965
Conversation
…nd not trip up Bikeshed's highlighting.
… undefined specially. Fixes whatwg#962.
…to a nullable or union type.
|
Ready for review now! Based on discussion in #962:
|
| <thead> | ||
| <tr> | ||
| <th class="corner"></th> | ||
| <th><div><span>undefined</span></div> | ||
| <th><div><span>boolean</span></div> | ||
| <th><div><span>numeric types</span></div> | ||
| <th><div><span>bigint</span></div> | ||
| <th><div><span>string types</span></div> | ||
| <th><div><span>object</span></div> | ||
| <th><div><span>symbol</span></div> | ||
| <th><div><span>interface-like</span></div> | ||
| <th><div><span>callback function</span></div> | ||
| <th><div><span>dictionary-like</span></div> | ||
| <th><div><span>sequence-like</span></div> | ||
| </thead> |
There was a problem hiding this comment.
Note that every other table in this specification includes the closing </t[d|h|r]> tags.
There was a problem hiding this comment.
I mean, I'm happy to remove those from all the other tables too, it just wasn't relevant for this PR. I can do it in a followup.
There was a problem hiding this comment.
Well, doing it in a separate PR would make this diff cleaner.
There was a problem hiding this comment.
Just to close the loop: are you saying that removing the reformatting of this table is a requested change for an R+ here? Or is it just a drive-by preference, and a commitment to filing a clean-up PR afterwards reformatting the rest of the tables accordingly would be sufficient?
There was a problem hiding this comment.
It’s mainly a drive‑by preference for cleaner diffs.
There was a problem hiding this comment.
In that case, can you r+? Or else tell me that you won't r+ until I make the change?
There was a problem hiding this comment.
There might be some confusion here; @ExE-Boss is not an editor for this spec and is just doing a drive-by review.
There was a problem hiding this comment.
Ahhhh, the GH "Reviewer" UI is confusing, sorry about that. In that case could I get a review, Domenic? ^_^
Co-authored-by: ExE Boss <[email protected]>
undefinedto the distinguishability tableundefinedspecially, now that it's just an ordinary IDL value.Currently a draft because there's an open question in #962 (comment), don't merge until that's answered and likely has another commit addressing it.