Skip to content

Meta: move to GitHub Actions #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Meta: move to GitHub Actions #992

merged 3 commits into from
Jun 28, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Jun 22, 2021

No description provided.

@TimothyGu
Copy link
Member

LGTM if it works. I don't see Actions running on this PR though?

@domenic
Copy link
Member Author

domenic commented Jun 22, 2021

Yeah, that is a bit worrying. Maybe it's a function of the rights I have to the repo? :/

@domenic
Copy link
Member Author

domenic commented Jun 25, 2021

Yeah, so, we merged #987 but it's not deploying.

I'm somewhat hopeful that even if GitHub won't run first-time actions for PRs, it'll start running them after we merge this? So it might be worth trying to merge this and seeing what happens?

@annevk
Copy link
Member

annevk commented Jun 26, 2021

@heycam maybe you have to turn this on somewhere as admin?

@domenic
Copy link
Member Author

domenic commented Jun 28, 2021

Ahah, I had the wrong branch name. When that is corrected it ran. Can I get a green checkmark?

@domenic domenic merged commit d04c4f9 into master Jun 28, 2021
@domenic domenic deleted the gh-actions branch June 28, 2021 21:12
@annevk annevk mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants