Improve relativeBase

[brettz9]

I would like relativeBase to potentially be a relative path itself (relative to window.location.href) and for it to be possible for this to differ from the base URL for the URL supplied to resolveRefsAt.

For example, if I have:

JsonRefs.resolveRefsAt('languages.json', {relativeBase: localesBase});

...I'd wish for localesBase to only apply to refs within languages.json, but not to the path of languages.json itself.

[whitlockjc]

I agree. I ran into this as well and I think the reason I didn't fix this before was tests depend on it, but I can fix this.

[brettz9]

Bump :)

[brettz9]

Hi @whitlockjc : Do you expect you will have any time to work on this?

[whitlockjc]

I'm working on it as we speak. :) Sorry for the delay, I don't work on Swagger tooling during my day job work anymore.

[whitlockjc]

The new resolver is deprecating options.relativeBase and instead using options.location (*At APIs will set options.location based on the path provided). The plan will be to then use another option for providing this option.

[whitlockjc]

This should had been fixed as a result of 0fc28fa and f69260d If not, please feel free to reopen.

[brettz9]

Thanks! Will be happy to take a look as I have a chance again...

[brettz9]

Does the change away from "relativeBase" mean that it will no longer work with relative paths? I was using it in this way before and it doesn't seem to work with a change as it says the file cannot be found (at a path not taking into account my "location")...

[whitlockjc]

options.relativeBase no longer is supported in general. options.location is used to represent the location of the document being processed (absolute or relative) and then all relative references are resolved relative to that document as expected.