Skip to content

Conversation

DannyS712
Copy link
Contributor

@DannyS712 DannyS712 commented Aug 10, 2021

When showing file names, if a file name ends in '.vue' use Vue language highlighting for the examples markdown, instead of JavaScript. No support is added yet for any other language.
Update file-name test case to add vue examples. Requires disabling the fixCodeExamples config option for that test to have the intended Vue output in the docs.
Should be the final change needed to solve #98

When showing file names, if a file name ends in '.vue' use Vue language highlighting for the examples markdown, instead of JavaScript. No support is added yet for any other language
Disable fixing code examples for the file-rule example, and add vue examples
Including the Vue example
Got the description wrong
Missed two semicolons when updating for no auto fixes
@edg2s
Copy link
Member

edg2s commented Aug 10, 2021

Setting a filename seems like an indirect way of setting the language. I think there should be an explicit language setting. We can still fall back to the filename extension if it isn't set.

@DannyS712
Copy link
Contributor Author

Setting a filename seems like an indirect way of setting the language. I think there should be an explicit language setting. We can still fall back to the filename extension if it isn't set.

So can we do this, and then as a follow-up add the explicit language setting? I'm not sure how to do follow-ups in github like in gerrit

@edg2s
Copy link
Member

edg2s commented Aug 12, 2021

I'm not sure how to do follow-ups in github like in gerrit
It's sadly not really designed for it, but you can make a PR that merges the next commit into this branch, then it can be rebased later.

@edg2s edg2s merged commit 53b1541 into wikimedia:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants