Update amcache.py #104
Open
Update amcache.py #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solving some problems with csv exports.
|
|
||
| with open("timeline.csv", 'wb') as csvfile: | ||
| w=unicodecsv.writer(csvfile, encoding='utf-8') | ||
| headers = ["timestamp", "timestamp_type", "path", "sha0"] |
There was a problem hiding this comment.
Suggested change
| headers = ["timestamp", "timestamp_type", "path", "sha0"] | |
| headers = ["timestamp", "timestamp_type", "path", "sha1"] |
??
|
would you please explain the problems that you're looking to solve with this PR? for example, i see that the changes tweak the output behavior to emit results to hardcoded file names rather than stdout. why? |
|
Of course, in this link a user commented an error when trying to perform the parse (https://gist.github.com/williballenthin/ee512eacb672320f2df5), the problem was in the csvwriter declaration since when adding information to the file we obtained " TypeError: write() argument must be str, not bytes" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving some problems with csv exports.