Skip to content

Fix lint error #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Fix lint error #728

merged 2 commits into from
Feb 22, 2023

Conversation

natemoo-re
Copy link
Member

Changes

Update CI lint settings

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2023

⚠️ No Changeset found

Latest commit: 9bb1e53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jasikpark
Copy link
Contributor

I'm confused, didn't the update to vert remove those values?

@natemoo-re
Copy link
Member Author

I'm confused, didn't the update to vert remove those values?

That would explain why we're getting a lint warning! But the actual code seems fine at runtime? I dunno what's happening.

@jasikpark
Copy link
Contributor

hmm maybe I'm thinking of js.Wrapper?

norunners/vert@106a353

@jasikpark
Copy link
Contributor

see #644 for context

@jasikpark
Copy link
Contributor

@natemoo-re
Copy link
Member Author

hmm maybe I'm thinking of js.Wrapper?

norunners/vert@106a353

Yep, I think js.Wrapper is the thing that got removed. The Vert types have never been correct for some reason, so this is just a lint thing.

@natemoo-re natemoo-re merged commit e9959f6 into main Feb 22, 2023
@natemoo-re natemoo-re deleted the fix/ci branch February 22, 2023 17:19
@jasikpark
Copy link
Contributor

hmm ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants