ChipScreen - adding example for dynamic label #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bel. WheelPickerDialog - container self alignment and code cleanup.
ethanshar
reviewed
Apr 8, 2021
| const {selectedValue} = this.state; | ||
|
|
||
| return ( | ||
| <WheelPickerDialog |
There was a problem hiding this comment.
Why did you add a picker to the chip example screen?
Don't you think it's making the example screen a bit more complicated than needed?
What do you want to demonstrate here?
There was a problem hiding this comment.
That was a request by ux
ethanshar
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChipScreen - adding example for onPress to open Dialog and dynamic label.
Chip - moving default values from static.
WheelPickerDialog - container self-alignment and code cleanup.
Description
ChipScreen - adding example for dynamic label
Changelog
ChipScreen - adding example for onPress to open Dialog and dynamic label.